On 10/04/2012 06:44 PM, Blue Swirl wrote:
> On Thu, Oct 4, 2012 at 6:33 AM, Avi Kivity <a...@redhat.com> wrote:
>> On 10/03/2012 10:16 PM, Blue Swirl wrote:
>>> > +static MemoryListener kvm_io_listener = {
>>>
>>> const
>>>
>>
>> There is a list link field in there. It's a mixed data/ops structure
>> (perhaps we should make it a traditional ->ops-> pointer).
>
> I grepped for MemoryListener and in hw/xen_pt.c 'const' already
> exists, so it looked OK but the code actually copies the structure to
> writable memory.
Yes. We should probably switch to the standard object->ops->callback
pattern. I'll write a patch after this series is merged.
--
error compiling committee.c: too many arguments to function
