Re: [Qemu-devel] [PATCH 1/1] hmp: allow "bool" parameter to be optional

[Pavel Hrdina]

On 08/07/2012 03:52 PM, Andreas Färber wrote:
Am 07.08.2012 15:03, schrieb Pavel Hrdina:
Signed-off-by: Pavel Hrdina <phrd...@redhat.com>
This is in need of a more detailed commit message: What exactly is this
fixing? Or is this a preparation for a particular new command?
Andreas
Yes, this is preparation for update of savevm command. I forget to write 
it. And I think that in future this could be useful.

Pavel
---
  monitor.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/monitor.c b/monitor.c
index bbf30e6..2b3583c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3778,6 +3778,9 @@ static const mon_cmd_t *monitor_parse_command(Monitor 
*mon,
                      val = 1;
                  } else if (p - beg == 3 && !memcmp(beg, "off", p - beg)) {
                      val = 0;
+                } else if (*typestr == '?') {
+                    typestr++;
+                    break;
                  } else {
                      monitor_printf(mon, "Expected 'on' or 'off'\n");
                      goto fail;