Il 07/08/2012 06:02, David Gibson ha scritto: >> Perhaps it's better to do this unconditionally (on the delete path too) >> so that removals are processed without delay and we don't have closed >> fds hanging around in select(). > > Well, I understand that Alexey discussed the patch with Paolo and > Michael Tsirkin, and this was the preferred approach for now. Since > obviously no events will happen on deleted fds, removing them from the > select() is not really urgent.
Avi is not speaking about deleted fds, but about existing fds whose handlers are temporarily removed. I don't see it as a blocker for merging the patch because we've never observed it (and it's unlikely, because temporary removal of handlers typically occurs from within a handler, not from another thread). Paolo
