Eric Blake <ebl...@redhat.com> writes:
> On 07/25/2012 10:45 AM, Eric Blake wrote:
>> On 07/25/2012 10:25 AM, Anthony Liguori wrote:
>>> We don't use the standard C functions for conversion because we don't want
>>> to
>>> depend on the user's locale. All option names in QEMU are en_US in plain
>>> ASCII.
>>
>>>
>>> +static int opt_tolower(int ch)
>>> +{
>>> + if (ch >= 'A' && ch <= 'Z') {
>>> + return 'a' + (ch - 'A');
>
> P.S. This is not portable to EBCDIC, but I guess we don't care about
> compilation of qemu on a non-ASCII machine, so my review still stands.
Fortunately, even on S390, Linux uses ASCII under normal circumstances
:-)
Regards,
Anthony Liguori
>
>> Reviewed-by: Eric Blake <ebl...@redhat.com>
>>
>
> --
> Eric Blake ebl...@redhat.com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
