On 07/25/2012 10:25 AM, Anthony Liguori wrote: > We don't use the standard C functions for conversion because we don't want to > depend on the user's locale. All option names in QEMU are en_US in plain > ASCII.
[Wondering if I should bring up the US 'canceled' vs. UK 'cancelled' as a counterpoint to the claim of everything being en_US, but then again, I didn't find any use of 'cancelled' as an option in qapi-schema.json.] > > Signed-off-by: Anthony Liguori <aligu...@us.ibm.com> > --- > qemu-option.c | 53 +++++++++++++++++++++++++++++++++++++++++++++-------- > qemu-option.h | 2 ++ > 2 files changed, 47 insertions(+), 8 deletions(-) > > diff --git a/qemu-option.c b/qemu-option.c > index 8334190..6494c99 100644 > --- a/qemu-option.c > +++ b/qemu-option.c > @@ -89,6 +89,43 @@ const char *get_opt_value(char *buf, int buf_size, const > char *p) > return p; > } > > +static int opt_tolower(int ch) > +{ > + if (ch >= 'A' && ch <= 'Z') { > + return 'a' + (ch - 'A'); > + } else if (ch == '_') { > + return '-'; Slick - making case-insensitive comparison also fold '-' and '_' together :) Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature