Will merge Igors corrections into v6 Regards, Peter
On Wed, Jul 18, 2012 at 1:04 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 17 July 2012 15:58, Igor Mitsyanko <i.mitsya...@samsung.com> wrote: >> On 07/17/2012 05:37 PM, Peter Maydell wrote: >>> I would suggest two functions: >>> >>> int sdhci_slotint(SDHCIState *s) >>> which just calculates and returns the external interrupt line state >>> (might be able to make this 'static'), and > >> Ok, but I'd rather make sdhci_slotint() return uint8_t, to emphasize that >> this function returns a value of hardware SLOTINT register. > > That's fine; the thing I want to avoid is having by-hand updates > of slotint all over the code. > > -- PMM
