Luca,

One more comment on your patch: the logic in the following condition
does not fit the comment bellow it.

On Mon, Aug 13, 2007 at 10:37:41PM +0200, Luca Tettamanti wrote:
> +        if (use_dynamic_ticks() && dynticks_create_timer()) {
> +            /* dynticks disabled or failed to create a timer, fallback
> +             * to old code.
> +             */
> +        [old code follows] 

One should have 
        if (!use_dynamic_ticks() || dynticks_create_timer()) {
Instead.

Regards,

Dan.


Reply via email to