On 19 June 2012 16:24, Andreas Färber <afaer...@suse.de> wrote: > Am 19.06.2012 17:18, schrieb Peter Maydell: >> On 14 June 2012 16:14, Andreas Färber <afaer...@suse.de> wrote: >>> Commit ec5b06d (configure: ensure directory exists when creating symlinks) >>> moved the creation of directories into the symlink() function but forgot >>> the case where no symlink is created. >>> >>> This leads to build errors on arm Linux due to -I../linux-headers. >>> >>> Unbreak the build on arm Linux by reverting part of that commit. >> >> I think it would be better to just revert ec5b06d completely. >> The comment documenting the symlink() function says >> "# symbolically link $1 to $2. Portable version of "ln -sf" >> and "ln -sf" doesn't create the target directory, so symlink() >> should not either. > > I don't mind either way as long as the build gets fixed. Anthony?
It turns out that there are later changes to configure which rely on the auto-creation of the directory, so simple reversion isn't sufficient. Maybe your patch is the simplest fix after all. -- PMM
