Il 15/06/2012 18:51, Eric Blake ha scritto: > Looks reasonable, but it will affect libvirt: Right now, libvirt parses > the particular return code (qemu_monitor.c:qemuMonitorJSONBlockJob), and > translates > > DeviceNotActive => "No active operation on device" > ... > all others => "Unexpected error" > > so if this patch goes in but libvirt doesn't match, then libvirt will > have a regression in error message quality. Not the end of the world, > though, so don't hold back just because of libvirt. > Reviewed-by: Eric Blake <ebl...@redhat.com> > >> > @@ -1679,8 +1679,7 @@ >> > # @device: the device name >> > # >> > # Returns: Nothing on success >> > -# If no background operation is active on this device, >> > DeviceNotActive >> > -# If cancellation already in progress, DeviceInUse >> > +# If no background operation is active on this device, >> > BlockJobNotActive > What happened to DeviceInUse?
It wasn't being sent in reality. :) Paolo
