On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > The DeviceNotActive error is not a particularly good match, add > a separate one. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > blockdev.c | 4 ++-- > qapi-schema.json | 5 ++--- > qerror.c | 4 ++++ > qerror.h | 3 +++ > 4 files changed, 11 insertions(+), 5 deletions(-)
Looks reasonable, but it will affect libvirt: Right now, libvirt parses the particular return code (qemu_monitor.c:qemuMonitorJSONBlockJob), and translates DeviceNotActive => "No active operation on device" ... all others => "Unexpected error" so if this patch goes in but libvirt doesn't match, then libvirt will have a regression in error message quality. Not the end of the world, though, so don't hold back just because of libvirt. Reviewed-by: Eric Blake <ebl...@redhat.com> > @@ -1679,8 +1679,7 @@ > # @device: the device name > # > # Returns: Nothing on success > -# If no background operation is active on this device, > DeviceNotActive > -# If cancellation already in progress, DeviceInUse > +# If no background operation is active on this device, > BlockJobNotActive What happened to DeviceInUse? -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
