On Wed, Jun 13, 2012 at 01:48:14PM +0200, Jan Kiszka wrote: > On 2012-06-13 13:22, Michael S. Tsirkin wrote: > > On Wed, Jun 13, 2012 at 01:15:23PM +0200, Jan Kiszka wrote: > >> On 2012-06-12 17:15, Michael S. Tsirkin wrote: > >>> On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote: > >>>> This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7. > >>>> > >>>> This function is used by a later patch to parse the BDF of the device to > >>>> passthrough. > >>>> > >>>> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > >>> > >>> You probably want to parse the host address? You don't want to copy the > >>> bugs in pci_parse_devaddr - write your own that has sane semantics > >>> for host. E.g. you need to support ARI etc. > >> > >> We should really consolidate over one parser for Xen, KVM device > >> assignment and VFIO. It looks like they all have very similar requirements. > > > > Also rename pci_parse_devaddr to pci_parse_legacy_devaddr > > to stress it's not something others should reuse. > > That depends on what pci_parse_devaddr will do in the end. If it will > become as general as my qemu_parse_pci_devaddr, "legacy" would be > inappropriate. > > Jan
I'd rather keep it separate than adding OPT_LEGACY. > -- > Siemens AG, Corporate Technology, CT T DE IT 1 > Corporate Competence Center Embedded Linux
