On 2012-06-13 14:40, Anthony PERARD wrote: > On 13/06/12 13:00, Jan Kiszka wrote: >> On 2012-06-13 13:22, Stefano Stabellini wrote: >>> On Wed, 13 Jun 2012, Jan Kiszka wrote: >>>> On 2012-06-12 17:15, Michael S. Tsirkin wrote: >>>>> On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote: >>>>>> This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7. >>>>>> >>>>>> This function is used by a later patch to parse the BDF of the device to >>>>>> passthrough. >>>>>> >>>>>> Signed-off-by: Anthony PERARD<anthony.per...@citrix.com> >>>>> >>>>> You probably want to parse the host address? You don't want to copy the >>>>> bugs in pci_parse_devaddr - write your own that has sane semantics >>>>> for host. E.g. you need to support ARI etc. >>>> >>>> We should really consolidate over one parser for Xen, KVM device >>>> assignment and VFIO. It looks like they all have very similar requirements. >>>> >>>> For those how didn't follow the discussion, see patches 10-13 in >>>> http://thread.gmane.org/gmane.comp.emulators.qemu/153728. >>> >>> I agree, actually it looks like patch 10 and 11 would be enough. >>> >>> Maybe you could extract them and send them out separately? >> >> They are still under discussion and waiting for some QOM refactorings to >> be merged. >> >> Will you be able to use an address parser via some device property? > > Yes. Actually, the address is already a device property. >
Great. Then we should try to come up with a common pci-host-devaddr property everyone can use. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux
