On Sun, Jun 03, 2012 at 01:17:57PM +0200, Hervé Poussineau wrote:
> >It is better to prefix all global scope symbols with
> >esp_ consistently. Reduces the chance of a conflict.
>
> All these functions are local to the file. I'll change that to
> pci_esp_... like other PCI-related functions in this file.
esp_pci would be clearer and preferable.
> >
> >>+static void pci_esp_dma_write(PCIESPState *pci, uint32_t saddr, uint32_t
> >>val)
> >>+{
> >>+ trace_esp_pci_dma_write(saddr, pci->dma_regs[saddr], val);
> >>+ switch (saddr) {
> >>+ case DMA_CMD:
> >>+ pci->dma_regs[saddr] = val;
> >>+ switch (val & DMA_CMD_MASK) {
> >>+ case 0x0: /* IDLE */
> >>+ trace_esp_pci_dma_idle(val);
> >>+ break;
> >>+ case 0x1: /* BLAST */
> >>+ pci_handle_blast(pci, val);
> >
> >fall-through intentional?
>
> Not at all. Thanks.
>
> Hervé
