Michael S. Tsirkin a écrit :
On Sun, Jun 03, 2012 at 12:38:09PM +0200, Hervé Poussineau wrote:
The PCI version is supported in lots of Operating Systems,
and has been successfully tested on:
- MS DOS 6.22 with MS Windows 3.11
- MS Windows 98 SE
- MS Windows NT 4.0
Signed-off-by: Hervé Poussineau <hpous...@reactos.org>
...
+
+static void pci_handle_abort(PCIESPState *pci, uint32_t val)
+{
+ trace_esp_pci_dma_abort(val);
+ if (pci->esp.current_req) {
+ scsi_req_cancel(pci->esp.current_req);
+ }
+}
+
It is better to prefix all global scope symbols with
esp_ consistently. Reduces the chance of a conflict.
All these functions are local to the file. I'll change that to
pci_esp_... like other PCI-related functions in this file.
+static void pci_esp_dma_write(PCIESPState *pci, uint32_t saddr, uint32_t val)
+{
+ trace_esp_pci_dma_write(saddr, pci->dma_regs[saddr], val);
+ switch (saddr) {
+ case DMA_CMD:
+ pci->dma_regs[saddr] = val;
+ switch (val & DMA_CMD_MASK) {
+ case 0x0: /* IDLE */
+ trace_esp_pci_dma_idle(val);
+ break;
+ case 0x1: /* BLAST */
+ pci_handle_blast(pci, val);
fall-through intentional?
Not at all. Thanks.
Hervé
