On Wed, 11 Jun 2025, Stefan Hajnoczi wrote:
On Wed, Jun 11, 2025 at 3:25 PM BALATON Zoltan <bala...@eik.bme.hu> wrote:
On Wed, 11 Jun 2025, Stefan Hajnoczi wrote:
From: oltolm <oleg.tolmat...@gmail.com>
Sorry, I forgot to cc the maintainers.
Do we want comments like this end up in git log? This could have been
fixed before a pull. Also the other pull request about uninitialised stack
variables had hw/audio/gus twice which was pointed out by a comment before
the pull that one of those should be different but the pull request still
had this error. Did you miss these or aren't these important enough to fix
before getting in git log forever or there is just no easy way to fix up
commit messages in pull requests?
If another reviewer asks for the author to resend then I'll hold off
on merging, but I didn't see the comment about hw/audio/gus. Sorry!
I did see this "Sorry, I forgot to cc the maintainers" comment.
Although I'm not consistent, nowadays I generally do not fix these
issues when merging, provided it's a small issue that can be ignored
or understood from the context.
I don't really mind either way, so if there is a consensus that all
maintainers should be strict about this, I'm happy to join.
I wouldn't ask maintainers to fixup commits regularly, especially changing
the patch itself would need resend from the author but for small typos in
commit message only it might be OK to fix them up on commit if noticed
before a pull. Just because if these aren't fixed they will be in git log
forever.
Regards,
BALATON Zoltan
