Markus Armbruster <arm...@redhat.com> writes: > Philippe Mathieu-Daudé <phi...@linaro.org> writes: > >> On 4/6/25 08:44, Markus Armbruster wrote: >>> Alex Bennée <alex.ben...@linaro.org> writes: >>> >>>> Markus Armbruster <arm...@redhat.com> writes: >>>> >>>>> From: Daniel P. Berrangé <berra...@redhat.com> >>>>> >>>>> Currently we have a short paragraph saying that patches must include >>>>> a Signed-off-by line, and merely link to the kernel documentation. >>>>> The linked kernel docs have a lot of content beyond the part about >>>>> sign-off an thus are misleading/distracting to QEMU contributors. >>>>> >>>>> This introduces a dedicated 'code-provenance' page in QEMU talking >>>>> about why we require sign-off, explaining the other tags we commonly >>>>> use, and what to do in some edge cases. >>>>> >>>>> Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> >>>>> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> >>>>> Signed-off-by: Markus Armbruster <arm...@redhat.com> >>>>> --- >>>>> docs/devel/code-provenance.rst | 218 ++++++++++++++++++++++++++++++ >>>>> docs/devel/index-process.rst | 1 + >>>>> docs/devel/submitting-a-patch.rst | 18 +-- >>>>> 3 files changed, 221 insertions(+), 16 deletions(-) >>>>> create mode 100644 docs/devel/code-provenance.rst >> >> >>>>> + >>>>> + Signed-off-by: YOUR NAME <YOUR@EMAIL> >>>>> + >>>>> +using a known identity (sorry, no anonymous contributions.) >>>>> + >>>> >>>> maybe "(contributions cannot be anonymous)" is more direct? >>> If we're deviating from the kernel's text (which is *fine*), let's get >>> rid of the parenthesis: >>> using a known identity. Contributions cannot be anonymous. >>> or in active voice: >>> using a known identity. We cannot accept anonymous contributions. >> >> I'd add an anchor in the "commonly known identity" paragraph added in >> commit 270c81b7d59 and here link to it. > > Makes sense, thanks!
Hmm, this splits the information between code-provenance.rst and submitting-a-patch.rst. The latter spot already links to the former. Let's move the paragraph here. >>> I like this one the best.