This series enables ACPI PCI hotplug/hotunplug on ARM and makes it default for 10.1 machine type. This aligns with x86 q35 machine. Expected benefits should be similar to those listed in [1], ie. removal of some racy behaviors, improved latencies.
It is still possible to disable it using a virt machine option: virt,acpi-pcihp=off and restore the legacy behavior. The infrastructure used in x86 is heavily reused and a huge part of the series consists in moving code from hw/i386/acpi-build.c to a generic place and slightly adapting it to make it usable on ARM. The DSDT table is augmented to support ACPI PCI hotplug elements. On ARM we use use a GED event to notify the OS about hotplug events. Best Regards Eric This series can be found at: https://github.com/eauger/qemu/tree/arm-acpi-pcihp-v2 previous series: https://github.com/eauger/qemu/tree/arm-acpi-pcihp-v1 History: v1 -> v2: - collected a bunch of R-bs from Gustavo (many thanks!) - Fixed the breakage of bios-tables-test in TCG mode by incorporating Gustavo's patches (part of [PATCH 0/5] ACPI tests for PCI Hotplug on ARM https://lore.kernel.org/all/20250526053123.1434204-1-gustavo.rom...@linaro.org/) - Tweeked the dsdt aml changes to avoid any dsdt blob difference when acpi-pcihp is off. RFC -> v1: - First 3 trivial patches were pulled separately - Fix of the register region size (0x18), ie. ACPI_PCIHP_SIZE - addition of aml_pci_edsm which was not called in RFC - acpi-index feature is now fixed. vms->bus was not set on acpi_pcihp_init. The init sequence is still hacky though. Suggestions are welcome. [1] [PATCH v6 0/6] Use ACPI PCI hot-plug for Q35 https://lore.kernel.org/all/20210713004205.775386-1-jus...@redhat.com/ Eric Auger (22): hw/i386/acpi-build: Make aml_pci_device_dsm() static hw/arm/virt: Introduce machine state acpi pcihp flags and props hw/acpi: Rename and move build_x86_acpi_pci_hotplug to pcihp hw/pci-host/gpex-acpi: Add native_pci_hotplug arg to acpi_dsdt_add_pci_osc hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation hw/pci-host/gpex-acpi: Propagate hotplug type info from virt machine downto gpex hw/i386/acpi-build: Turn build_q35_osc_method into a generic method hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method hw/i386/acpi-build: Introduce build_append_pcihp_resources() helper hw/acpi/pcihp: Add an AmlRegionSpace arg to build_acpi_pci_hotplug hw/i386/acpi-build: Move build_append_notification_callback to pcihp hw/i386/acpi-build: Move build_append_pci_bus_devices/pcihp_slots to pcihp hw/i386/acpi-build: Introduce and use acpi_get_pci_host hw/i386/acpi-build: Move aml_pci_edsm to a generic place hw/arm/virt-acpi-build: Modify the DSDT ACPI table to enable ACPI PCI hotplug hw/acpi/ged: Prepare the device to react to PCI hotplug events hw/acpi/ged: Call pcihp plug callbacks in hotplug handler implementation hw/acpi/ged: Support migration of AcpiPciHpState hw/core/sysbus: Introduce sysbus_mmio_map_name() helper hw/arm/virt: Let virt support pci hotplug/unplug GED event hw/arm/virt: Plug pcihp hotplug/hotunplug callbacks hw/arm/virt: Use ACPI PCI hotplug by default Gustavo Romero (3): tests/qtest/bios-tables-test: Prepare for changes in the DSDT table tests/qtest/bios-tables-test: Update DSDT blobs after GPEX _OSC change tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off hw/i386/acpi-build.h | 4 - include/hw/acpi/aml-build.h | 2 + include/hw/acpi/generic_event_device.h | 7 + include/hw/acpi/pci.h | 4 +- include/hw/acpi/pcihp.h | 19 +- include/hw/arm/virt.h | 4 + include/hw/pci-host/gpex.h | 1 + include/hw/sysbus.h | 1 + hw/acpi/aml-build.c | 50 ++ hw/acpi/generic_event_device.c | 54 ++ hw/acpi/pci.c | 20 + hw/acpi/pcihp.c | 482 ++++++++++++++- hw/arm/virt-acpi-build.c | 23 + hw/arm/virt.c | 107 +++- hw/core/sysbus.c | 11 + hw/i386/acpi-build.c | 552 +----------------- hw/pci-host/gpex-acpi.c | 75 +-- tests/qtest/bios-tables-test.c | 13 +- hw/arm/Kconfig | 2 + tests/data/acpi/aarch64/virt/DSDT | Bin 5196 -> 5170 bytes .../data/acpi/aarch64/virt/DSDT.acpihmatvirt | Bin 5282 -> 5256 bytes tests/data/acpi/aarch64/virt/DSDT.memhp | Bin 6557 -> 6531 bytes tests/data/acpi/aarch64/virt/DSDT.pxb | Bin 7679 -> 7627 bytes tests/data/acpi/aarch64/virt/DSDT.topology | Bin 5398 -> 5372 bytes 24 files changed, 812 insertions(+), 619 deletions(-) -- 2.49.0
