On Fri, 9 May 2025 15:32:30 +0800
Zhao Liu <zhao1....@intel.com> wrote:
> On Fri, May 09, 2025 at 02:49:27PM +0800, Xiaoyao Li wrote:
> > Date: Fri, 9 May 2025 14:49:27 +0800
> > From: Xiaoyao Li <xiaoyao...@intel.com>
> > Subject: Re: [PATCH v4 12/27] target/i386/cpu: Remove
> > CPUX86State::enable_cpuid_0xb field
> >
> > On 5/8/2025 9:35 PM, Philippe Mathieu-Daudé wrote:
> > > The CPUX86State::enable_cpuid_0xb boolean was only disabled
> > > for the pc-q35-2.6 and pc-i440fx-2.6 machines, which got
> > > removed. Being now always %true, we can remove it and simplify
> > > cpu_x86_cpuid().
> > >
> > > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
...
> > > @@ -8828,7 +8823,6 @@ static const Property x86_cpu_properties[] = {
> > > DEFINE_PROP_UINT64("ucode-rev", X86CPU, ucode_rev, 0),
> > > DEFINE_PROP_BOOL("full-cpuid-auto-level", X86CPU,
> > > full_cpuid_auto_level, true),
> > > DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor),
> > > - DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true),
...
> @Philippe, thank you for cleaning up this case! I think we can keep this
> property, and if you don't mind, I can modify its comment later to
> indicate that it's used to adjust the topology support for the CPU.
+1, we should not delete this without due process (aka deprecation).
So perhaps deprecate now and remove in couple of releases
