Re: [RFC PATCH v4 12/19] hw/arm/virt: Register valid CPU types dynamically

[Philippe Mathieu-Daudé]

On 22/4/25 19:56, Richard Henderson wrote:

On 4/22/25 07:54, Philippe Mathieu-Daudé wrote:

+#ifdef CONFIG_TCG

+        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("cortex-a7"))); +        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("cortex-a15")));

+#ifdef TARGET_AARCH64

+        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("cortex-a35"))); +        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("cortex-a55"))); +        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("cortex-a72"))); +        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("cortex-a76"))); +        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("cortex-a710"))); +        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("a64fx"))); +        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("neoverse-n1"))); +        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("neoverse-v1"))); +        vct = g_slist_prepend(vct, g_strdup(ARM_CPU_TYPE_NAME("neoverse-n2")));

+#endif /* TARGET_AARCH64 */

Why do these need to be strdup'ed?

g_slist_prepend() expects non-const.

Do you anticipate other instances where these names cannot be constructed at compile-time?

r~