On Tue, Apr 01, 2025 at 09:01:22AM -0400, Xiaoyao Li wrote: > Date: Tue, 1 Apr 2025 09:01:22 -0400 > From: Xiaoyao Li <xiaoyao...@intel.com> > Subject: [PATCH v8 12/55] i386/tdx: Validate TD attributes > X-Mailer: git-send-email 2.34.1 > > Validate TD attributes with tdx_caps that only supported bits are > allowed by KVM. > > Besides, sanity check the attribute bits that have not been supported by > QEMU yet. e.g., debug bit, it will be allowed in the future when debug > TD support lands in QEMU. > > Signed-off-by: Xiaoyao Li <xiaoyao...@intel.com> > Acked-by: Gerd Hoffmann <kra...@redhat.com> > --- > Changes in v8: > - Split the mrconfigid/mrowner/mrownerconfig part into a seperate next > patch; > > Changes in v7: > - Define TDX_SUPPORTED_TD_ATTRS as QEMU supported mask, to validates > user's request. (Rick) > > Changes in v3: > - using error_setg() for error report; (Daniel) > --- > target/i386/kvm/tdx.c | 32 ++++++++++++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-)
Overall LGTM, (with Daniel's comment fixed) Reviewed-by: Zhao Liu <zhao1....@intel.com>
