On Fri, Mar 21, 2025 at 3:26 PM Peter Maydell <peter.mayd...@linaro.org> wrote: > Tested-by: Peter Maydell <peter.mayd...@linaro.org> > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > > If I understand the code correctly I think you could also > write this as "addr & 0x1f" which might be a little nicer > as it then lines up with the "/ 0x20".
Yeah, I was undecided between that and 0x18... in the end I went with 0x18 because bits 0-1 are clear (due to alignment) and bit 2 is cleared above, and the TimerRegister enum also has "0x18" in the comment. Paolo
