On 4/4/2025 8:25 AM, Matheus Tavares Bernardino wrote:
On Thu, 3 Apr 2025 19:51:58 -0700 Brian Cain <brian.c...@oss.qualcomm.com>
wrote:
From: Brian Cain <bc...@quicinc.com>
Perhaps it would be best to reset the autorship here to
brian.c...@oss.qualcomm.com?
Good catch -- will do.
Signed-off-by: Brian Cain <brian.c...@oss.qualcomm.com>
---
target/hexagon/hex_common.py | 27 ++++++++++++++++++++++-----
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
index 758e5fd12d..242dee3731 100755
--- a/target/hexagon/hex_common.py
+++ b/target/hexagon/hex_common.py
@@ -349,6 +349,12 @@ def helper_arg(self):
self.reg_tcg(),
f"{self.helper_arg_type()} {self.helper_arg_name()}"
)
+ def from_subtype(self, subtype):
+ if subtype == "":
+ return self
+ raise Exception(
+ f"unknown subtype '{subtype}' on generic Register class")
+
We use this method for other reg types downstream (HVX). Since, in this patch
series, we are not really using from_subtype (get_register is always called
with subtype == ""), I think we could either exclude it from this series or
evaluate how to also upstream its use for HVX.
