On Thu, 3 Apr 2025 17:18:28 +0200 Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
> GIC ITS can be disabled at runtime using '-M its=off', > which sets VirtMachineState::its = false. Check this > field to avoid advertising the ITS in the MADT table. > > Reported-by: Udo Steinberg <u...@hypervisor.org> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2886 > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> > Reviewed-by: Gustavo Romero <gustavo.rom...@linaro.org> > --- > hw/arm/virt-acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > index e7e27951cb9..38a9e6fe0c5 100644 > --- a/hw/arm/virt-acpi-build.c > +++ b/hw/arm/virt-acpi-build.c > @@ -212,7 +212,7 @@ static bool its_enabled(VirtMachineState *vms) > { > VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms); > > - return !vmc->no_its; > + return !vmc->no_its && vms->its; It's confusing have both no_its and its, it would be better to lean this mess up (i.e dedup or rename if something is poorly named) > } > > /*
