Re: [PATCH-for-10.0 v2 03/14] tests/functional: Skip aarch64_replay test on macOS

[Richard Henderson]

On 4/3/25 08:18, Philippe Mathieu-Daudé wrote:

As of v10.0.0-rc2 this test is still failing on macos:

   $ make check-functional-aarch64 V=1
   ...
   ERROR:../../replay/replay-internal.c:235:replay_mutex_unlock: assertion 
failed: (replay_mutex_locked())
   Bail out! ERROR:../../replay/replay-internal.c:235:replay_mutex_unlock: 
assertion failed: (replay_mutex_locked())

This is tracked as https://gitlab.com/qemu-project/qemu/-/issues/2907

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  tests/functional/test_aarch64_replay.py | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Acked-by: Richard Henderson <richard.hender...@linaro.org>

r~

diff --git a/tests/functional/test_aarch64_replay.py 
b/tests/functional/test_aarch64_replay.py
index 04cde433bcf..029fef3cbf8 100755
--- a/tests/functional/test_aarch64_replay.py
+++ b/tests/functional/test_aarch64_replay.py
@@ -5,7 +5,7 @@
  #
  # SPDX-License-Identifier: GPL-2.0-or-later

-from qemu_test import Asset

+from qemu_test import Asset, skipIfOperatingSystem
  from replay_kernel import ReplayKernelBase

@@ -16,6 +16,8 @@ class Aarch64Replay(ReplayKernelBase):

           'releases/29/Everything/aarch64/os/images/pxeboot/vmlinuz'),
          '7e1430b81c26bdd0da025eeb8fbd77b5dc961da4364af26e771bd39f379cbbf7')

+ # Failing on Darwin: https://gitlab.com/qemu-project/qemu/-/issues/2907

+    @skipIfOperatingSystem('Darwin')
      def test_aarch64_virt(self):
          self.set_machine('virt')
          self.cpu = 'cortex-a53'