On 25/03/25 22:45, Cédric Le Goater wrote:
On 3/25/25 18:07, Aditya Gupta wrote:
On 25/03/25 20:17, Cédric Le Goater wrote:
On 3/25/25 12:23, Aditya Gupta wrote:
<...snip...>
+ machine_class_allow_dynamic_sysbus_dev(mc, TYPE_PNV_PHB);
There was a lot of work done to have dynamic PHBs in the PowerNV
machines. This was to add support in libvirt and this goal was
abandoned when people left. I think we should consider removing
it as it adds unnecessary complexity.
Thanks for telling the history behind it, agreed this is unnecessary,
will remove in v7.
One nice about it IIRC was being able to tune the number of
PHBs per chip, which reduced booting time (for 16s) and also
provided support to test various chip configs. Check that first.
I tried some variations of 'device_add/device_del'. Unable to see how to
dynamically add/remove phbs.
Do you have any options to device_add/del which I can try, I want to see
if the dynamic addition/removal of PHB changes if i remove that
'_allow_dynamic_sysbus_dev' call.
Also, you should add functional tests for the powernv11 machine.
See under tests/functional/test_ppc64_powernv.py.
Currently the test uses op-build kernels, which don't support Power11,
working on that side, will post as soon as op-build creates a new
release with p11 support (any linux >= 6.9).
Thanks,
- Aditya Gupta
Thanks,
C.
