On Tue, Feb 25, 2025 at 09:10:40AM +0530, Ani Sinha wrote:
> On Mon, Feb 24, 2025 at 9:01 PM Gerd Hoffmann <kra...@redhat.com> wrote:
> >
> > Hi,
> >
> > > /* should only be called once */
> > > - if (ovmf_flash_parsed) {
> > > + if (ovmf_flash_parsed && !force) {
> >
> > I think it makes more sense to clear ovmf_flash_parsed when replacing
> > the firmware (instead of adding the force override).
>
> I thought about that but wondered if that is an internal
> variable/implementation specific detail which should not be exposed
> outside.
You don't have to expose the variable directly, you can also provide a
helper function to clear it. Best with a name which documents the
purpose.
take care,
Gerd
