Hello Fabiano,
On Tue, 18 Feb 2025 at 19:58, Fabiano Rosas <faro...@suse.de> wrote:
> >> > +static void test_multifd_postcopy_tcp_cancel(void)
> >> > +{
> >> > + postcopy_ram = true;
> >> > + test_multifd_tcp_cancel();
> >> > + postcopy_ram = false;
> >>
> >> You could pass this in, there's just one other caller.
>
> To make postcopy_ram be passed in as an argument to
> test_multifd_tcp_cancel(). Having globals tend to get in the way of
> refactoring stuff later. We already had issues with tmpfs being global
> all over the place.
* This looks tricky to do. test_multifd_tcp_cancel() is called via
migration_test_add(), which expects a function pointer of type => void
(*fn)(void). Changing 'migration_test_add' signature would entail
adding a parameter to all functions called by it.
Thank you.
---
- Prasad
