On Mon, 17 Feb 2025 at 21:03, Fabiano Rosas <faro...@suse.de> wrote:
> > @@ -110,6 +129,10 @@ void migration_test_add_postcopy(MigrationTestEnv *env)
> > "/migration/postcopy/recovery/double-failures/reconnect",
> > test_postcopy_recovery_fail_reconnect);
> >
> > + migration_test_add("/migration/multifd+postcopy/plain",
> > + test_multifd_postcopy);
> > + migration_test_add("/migration/multifd+postcopy/preempt/plain",
> > + test_multifd_postcopy_preempt);
>
> For postcopy-tests.c I'd use /migration/postcopy/multifd so we can run
> them all via command-line. These are also the only ones actually doing
> postcopy migration. We need to distinguish multifd+postcopy proper from
> merely postcopy-ram=true.
* ie. repalce 'multifd+postcopy' with '../postcopy/multifd/' only in
postcopy-tests.c? And keep other instances unchanged?
...
> >
> > +static void test_multifd_postcopy_tcp_cancel(void)
> > +{
> > + postcopy_ram = true;
> > + test_multifd_tcp_cancel();
> > + postcopy_ram = false;
>
> You could pass this in, there's just one other caller.
* Sorry, what do you mean here?
Thank you.
---
- Prasad
