On 2025/01/17 22:12, Daniel P. Berrangé wrote:
On Sat, Jan 11, 2025 at 05:07:48PM +0900, Akihiko Odaki wrote:
Check more text files: Objective-C, Meson, "hx", JSON, and property
list.
Objective-C looks sensible at least.
For the others though, I'm wondering if any of the current checks
performed are liable to cause false positives for these files ?
The process subroutine says $SrcFile will enable the following checks:
- 90 column limit; exempt URLs, if no other words on line
- check for spaces before a quoted newline
- check for adding lines without a newline.
- check for RCS/CVS revision markers
- tabs are only allowed in assembly source code, and in
some scripts we imported from other projects.
They look valid for most text files, if not all.
Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 06d07e6c225c..94ac5230b48f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -12,7 +12,7 @@ use Term::ANSIColor qw(:constants);
my $P = $0;
$P =~ s@.*/@@g;
-our $SrcFile = qr{\.(?:(h|c)(\.inc)?|cpp|s|S|pl|py|sh)$};
+our $SrcFile = qr{\.(?:(h|c|m)(\.inc)?|cpp|s|S|pl|py|sh|build|hx|json|plist)$};
my $V = '0.31';
---
base-commit: 38d0939b86e2eef6f6a622c6f1f7befda0146595
change-id: 20250111-checkpatch-26ea9d86c76a
Best regards,
--
Akihiko Odaki <akihiko.od...@daynix.com>
With regards,
Daniel
