On 11/26/24 07:59, Philippe Mathieu-Daudé wrote:
Historically we were only calling decode_opc() from the MIPS
translate_insn() handler. Then variable instruction length
ISAs were added, we kept using the same pattern but call
yet more translator_ld() in the callees when necessary.

This is cumbersome and bug prone, so better move all
translator_ld() calls to the callees where it is more
logical.

Signed-off-by: Philippe Mathieu-Daudé<phi...@linaro.org>
---
  target/mips/tcg/translate.c               |  6 ++----
  target/mips/tcg/micromips_translate.c.inc |  3 +++
  target/mips/tcg/mips16e_translate.c.inc   |  5 +++--
  target/mips/tcg/nanomips_translate.c.inc  | 12 +++++++++---
  4 files changed, 17 insertions(+), 9 deletions(-)

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~

Reply via email to