Am 18.04.2012 16:11, schrieb Stefan Hajnoczi: > On Wed, Apr 18, 2012 at 2:37 PM, Lluís Vilanova <vilan...@ac.upc.edu> wrote: >> Stefan Hajnoczi writes: >> >>> On Sat, Apr 14, 2012 at 12:19:03AM +0200, Lluís Vilanova wrote: >>>> - rm -f $(GENERATED_HEADERS) >>>> - rm -f $(GENERATED_SOURCES) >>>> + rm -f $(foreach f,$(GENERATED_HEADERS),$(f) $(f)-timestamp */$(f) >>>> */$(f)-timestamp) >>>> + rm -f $(foreach f,$(GENERATED_SOURCES),$(f) $(f)-timestamp */$(f) >>>> */$(f)-timestamp) >> >>> Why */$(f) */$(f)-timestamp? >> >> Some of the files are generated in immediate subdirectories (e.g., >> libuser/trace.c-timestamp). >> >> I could use the results of a call shell to "find" instead, so that it will >> always find the right victims no matter where they are. > > Ah, I get it. This actually adds something that was missing previously. > > I'm not a make expert, I think if we try we can find issues with any > approach to removing the files. What you've done seems fine to me :).
Er, nack. libuser has its own Makefile.user, so we should recurse into libuser and rm from there. Is there an actual problem here apart from *-timestamp? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
