On 29/10/2024 11:22, Peter Maydell wrote:
On Wed, 23 Oct 2024 at 09:59, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote:This series contains a number of tidy-ups and improvements to the NeXTCube machine which include: - Bringing the code up-to-date with our latest coding standards/APIs, in particular related to the board configuration and IRQ wiring - Remove the remaining overlapping memory regions and consolidating multiple register implementations into a single place - Add a new next-scsi device containing the ESP device and its associated CSRs - Adding the empty_slot device to fill unimplemented devices and removing the "catch-all" next.scr memory region - QOMifying the next-rtc device and wiring it up with gpios as required The next-cube machine looks in fairly good shape now, the main remaining work is to create a separate device for the DMA controller and update the wiring of the IRQs (including to the CPU) accordingly.Would you have time to consider updating hw/m68k/next-kbd.c to stop using qemu_add_kbd_event_handler()? It's the only user left in the codebase of that input-legacy.c API. Generally using qemu_input_handler_register() should simplify the code because it will no longer need to decode multi-byte PS2 code sequences back into "what is the single key event that this corresponds to?". Commit ff7888dcc6c701 is an example of the conversion (though that input device is somewhat simpler than a full real keyboard).
Sure, I'll have a look and see if I can manage it - removing legacy APIs is always a good thing :)
ATB, Mark.
