On 10/28/24 01:41, Jan Lübbe wrote:
On Sun, 2024-10-27 at 20:32 -0700, Guenter Roeck wrote:
On 10/27/24 15:26, Cédric Le Goater wrote:
On 10/27/24 23:11, Guenter Roeck wrote:
On 10/27/24 14:13, Cédric Le Goater wrote:
On 10/26/24 17:32, Guenter Roeck wrote:
On 10/26/24 03:02, Cédric Le Goater wrote:
[ ... ]


Works for me, though, and it is much better than mandating the existence
of boot partitions.

Yes. However, if the emmc device was user creatable, we could use :

    -blockdev node-name=emmc0,driver=file,filename=mmc-ast2600-evb-noboot.raw \
    -device emmc,bus=sdhci-bus.2,drive=emmc0

and with boot partitions:

    -M boot-emmc=true \
    -blockdev node-name=emmc0,driver=file,filename=mmc-ast2600-evb.raw \
    -device 
emmc,bus=sdhci-bus.2,drive=emmc0,boot-partition-size=1048576,boot-config=8

The above would be my preferred approach if acceptable. The "sd-bus"
bus identifier should be changed in other machines tough.

No real preference here, though my understanding is that emmc devices
are by definition built-in, and that is what emmc_class_init() says as well.
Also, there does not seem to be an sdhci-bus, only sd-bus, and that does
not support any index values. That may be just my lack of knowledge, though.

No, you are right. On a real ast2600-evb, the eMMC device is indeed
soldered on the board. But, for testing purposes, it is sometime
interesting to add some flexibility in the machine definition and
in the modeling too. This avoids "hard-coding" default devices in
the machines and lets the user define its own variant models using
the QEMU command line.

I would agree, but I had a number of my patches rejected because while
they would be useful for testing they would not accurately reflect the
hardware. So nowadays I gave up even trying to upstream such changes.

My patch to make eMMCs user creatable [1] was applied to target-
arm.next by Peter Maydell [2] last week.


That works for me with

drivecmd="-drive file=${ROOTFS},format=raw,if=none,id=d0"
drivecmd+=" -device emmc,drive=d0"

but unless I am missing something

drivecmd="-drive file=${ROOTFS},format=raw,if=none,id=d0"
drivecmd+=" -device sd-card,drive=d0"

also boots from the emmc controller. How do I provide the
bus and bus index ? "bus=sdhci-bus.2" doesn't work for me.
There is "sd-bus", but it does not have an index.

Thanks,
Guenter


Reply via email to