Am 13.04.2012 14:33, schrieb Stefan Hajnoczi: > On Thu, Apr 12, 2012 at 4:01 PM, Kevin Wolf <kw...@redhat.com> wrote: >> This changes the still existing places that assume that the only flags >> are QCOW_OFLAG_COPIED and QCOW_OFLAG_COMPRESSED to properly mask out >> reserved bits. >> >> It does not convert bdrv_check yet. >> >> Signed-off-by: Kevin Wolf <kw...@redhat.com> >> --- >> block/qcow2-cluster.c | 26 +++++++++++++------------- >> block/qcow2-refcount.c | 12 ++++++------ >> 2 files changed, 19 insertions(+), 19 deletions(-) > > It would be interesting to run a test case where we artifically set a > reserved bit to gain confidence that no important codepath has been > missed. Thoughts?
Patches gladly accepted. ;-) I agree that we want to add such test cases to qemu-iotests. Functionality that sets reserved bits would fit well into qcow2.py. I just didn't get to it yet. Kevin
