On Wed, Oct 09, 2024 at 04:46:01PM -0700, Yichen Wang wrote: > diff --git a/util/meson.build b/util/meson.build > index 5d8bef9891..3360f62923 100644 > --- a/util/meson.build > +++ b/util/meson.build > @@ -88,6 +88,9 @@ if have_block or have_ga > endif > if have_block > util_ss.add(files('aio-wait.c')) > + if config_host_data.get('CONFIG_DSA_OPT') > + util_ss.add(files('dsa.c')) > + endif
It's not clear to me why this needs to be under have_block. Since we want to make sure this file is ignored on !x86, maybe it should be put under the "elif cpu in ['x86', 'x86_64']" section. > util_ss.add(files('buffer.c')) > util_ss.add(files('bufferiszero.c')) > util_ss.add(files('hbitmap.c')) > -- > Yichen Wang > -- Peter Xu