Paul Brook wrote: > > Fix do_socketcall argument, by Daniel Jacobowitz. > > > - static long do_socketcall(int num, target_ulong vptr) > > + static long do_socketcall(int num, target_phys_addr_t vptr) > > What is this supposed to be fixing? > vptr is a target pointer, and is only ever used as an argument to tgetl. > I think the original type (target_ulong) is correct. > > target_phys_addr_t isn't really meaningful for userspace emulation. > We don't have physical addresses, only target (target_ulong) and > host (void *) virtual addresses.
Reverted. I had it for so long in my local tree I forgot its purpose. :-) Thiemo