On Thu, Aug 01, 2024 at 07:11:01PM +0200, Philippe Mathieu-Daudé wrote:
> On 30/7/24 19:03, Daniel P. Berrangé wrote:
> > From: Thomas Huth <th...@redhat.com>
> >
> > These tests use archive.lzma_uncompress() from the Avocado utils,
> > so provide a small helper function for this, based on the
> > standard lzma module from Python instead.
> >
> > And while we're at it, replace the MD5 hashes in the topology test
> > with proper SHA256 hashes, since MD5 should not be used anymore
> > nowadays.
> >
> > Signed-off-by: Thomas Huth <th...@redhat.com>
> > ---
> > MAINTAINERS | 4 +-
> > tests/functional/meson.build | 6 ++
> > tests/functional/qemu_test/utils.py | 14 +++
> > .../test_s390x_ccw_virtio.py} | 79 ++++++++---------
> > .../test_s390x_topology.py} | 86 ++++++++-----------
> > 5 files changed, 94 insertions(+), 95 deletions(-)
> > rename tests/{avocado/machine_s390_ccw_virtio.py =>
> > functional/test_s390x_ccw_virtio.py} (85%)
> > mode change 100644 => 100755
> > rename tests/{avocado/s390_topology.py =>
> > functional/test_s390x_topology.py} (88%)
> > mode change 100644 => 100755
>
> Conversion LGTM, so:
>
> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
>
> Now while testing I'm getting errors, but maybe pre-existing...
What host arch / OS are you running tests from ?
I got through the full set of testing on Fedora x86_64, so
wondering if something differs.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
