On Mon May 27, 2024 at 9:12 AM AEST, BALATON Zoltan wrote:
> In ppc6xx_tlb_pte_check() the pteh variable is used only once to
> compare to the h parameter of the function. Inline its value and use
> pteh name for the function parameter which is more descriptive.
>
> Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu>
Reviewed-by: Nicholas Piggin <npig...@gmail.com>
> ---
> target/ppc/mmu_common.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c
> index 16578f7fa5..b21f52290f 100644
> --- a/target/ppc/mmu_common.c
> +++ b/target/ppc/mmu_common.c
> @@ -95,15 +95,14 @@ int ppc6xx_tlb_getnum(CPUPPCState *env, target_ulong
> eaddr,
> }
>
> static int ppc6xx_tlb_pte_check(mmu_ctx_t *ctx, target_ulong pte0,
> - target_ulong pte1, int h,
> + target_ulong pte1, int pteh,
> MMUAccessType access_type)
> {
> - int ret, pteh, pp;
> + int ret, pp;
>
> ret = -1;
> /* Check validity and table match */
> - pteh = (pte0 >> 6) & 1;
> - if (pte_is_valid(pte0) && h == pteh) {
> + if (pte_is_valid(pte0) && ((pte0 >> 6) & 1) == pteh) {
> /* Check vsid & api */
> pp = pte1 & 0x00000003;
> if ((pte0 & PTE_PTEM_MASK) == ctx->ptem) {
