On Thu, Jun 27, 2024 at 10:38 AM Manos Pitsidianakis <manos.pitsidiana...@linaro.org> wrote: > > On Thu, 27 Jun 2024 00:32, Paolo Bonzini <pbonz...@redhat.com> wrote: > >On Tue, Jun 25, 2024 at 9:17 PM Manos Pitsidianakis > ><manos.pitsidiana...@linaro.org> wrote: > >> >Move the macro to compiler.h and, while at it, move it under #ifndef > >> >__cplusplus to emphasize that it uses C-only constructs. A C++ version > >> >of typeof_strip_qual() using type traits is possible[1], but beyond the > >> >scope of this patch because the little C++ code that is in QEMU does not > >> >use QAPI. > >> > >> Should we add an #else to provide a fallback for cplusplus until the > >> alternative is merged? > > > >As the commit message says, I don't think we need to include the C++ > >code in QEMU since it would be essentially dead. > > The #ifndef __cplusplus part stood out for me, if it's not required for > the qemu build then it's similarly unnecessary. Thinking out loud here.
Yeah, the patch had actually two purposes, only one of which is explicit in the commit message because the other is more relevant to Google than to the upstream project: 1) Google wants some help making QEMU headers compilable with C++, which is generally not a goal of the project but not something we want to hinder. And if that brings to our attention things that could be improved in C as well, why not. 2) it is true that typeof_strip_qual() is useful in other places than qemu/atomic.h Since qemu/compiler.h already has #ifdef __cplusplus in various places, and could reasonably be included in the few C++ files that QEMU has, it makes sense to have a #ifndef __cplusplus in qemu/compiler.h (unlike in qemu/atomic.h). Personally I prefer to have a little more cognitive load in common headers such as qemu/osdep.h and qemu/compiler.h, than to have different styles (e.g. no qemu/osdep.h inclusion) in C++ sources, even though most likely I'll never touch those C++ sources. The #ifndef is not absolutely necessary---if we removed it, Google could work around that with "#ifdef __cplusplus / #undef typeof_strip_qual". It is mostly for documentation purposes to point out the C-only compiler builtins, and because if anyone ended up using typeof_strip_qual in C++ code the error message would be very very long. Paolo
