On Thu, 27 Jun 2024 00:32, Paolo Bonzini <pbonz...@redhat.com> wrote:
On Tue, Jun 25, 2024 at 9:17 PM Manos Pitsidianakis
<manos.pitsidiana...@linaro.org> wrote:
>Move the macro to compiler.h and, while at it, move it under #ifndef
>__cplusplus to emphasize that it uses C-only constructs. A C++ version
>of typeof_strip_qual() using type traits is possible[1], but beyond the
>scope of this patch because the little C++ code that is in QEMU does not
>use QAPI.
Should we add an #else to provide a fallback for cplusplus until the
alternative is merged?
As the commit message says, I don't think we need to include the C++
code in QEMU since it would be essentially dead.
The #ifndef __cplusplus part stood out for me, if it's not required for
the qemu build then it's similarly unnecessary. Thinking out loud here.
Anyway, ACK and tested-by and rob as in my previous mail.
Thanks,
Manos
