On Fri, 21 Jun 2024 at 17:52, shiju.jose--- via <qemu-devel@nongnu.org> wrote: > > From: Shiju Jose <shiju.j...@huawei.com> >
> diff --git a/hw/arm/arm_error_inject.c b/hw/arm/arm_error_inject.c > new file mode 100644 > index 0000000000..953a9d6705 > --- /dev/null > +++ b/hw/arm/arm_error_inject.c > @@ -0,0 +1,49 @@ > +/* > + * CXL Type 3 (memory expander) device This doesn't seem to match what the file actually does. > + * > + * Copyright(C) 2020 Intel Corporation. > + * > + * This work is licensed under the terms of the GNU GPL, version 2. See the > + * COPYING file in the top-level directory. > + * > + * SPDX-License-Identifier: GPL-v2-only Why are these new files GPL-v2-only? Our general preference (see the LICENSE) file is for GPL-v2-or-any-later-version. I also notice that this file is marked as copyright Intel, but you're submitting from a Huawei email address. What's the history of this code? > + */ > + > +#include "qemu/osdep.h" > +#include "qemu/units.h" > +#include "qemu/error-report.h" > +#include "qapi-commands-arm-error-inject.h" > +#include "hw/qdev-properties.h" > +#include "qapi/error.h" > +#include "qemu/log.h" > +#include "qemu/module.h" > +#include "qemu/pmem.h" > +#include "qemu/range.h" > +#include "qemu/rcu.h" > +#include "qemu/guest-random.h" > +#include "sysemu/hostmem.h" > +#include "sysemu/numa.h" > +#include "hw/boards.h" > +#include "hw/acpi/ghes.h" Looking at the code here I'm pretty sure you don't need anywhere near all of these include lines. > + > +#define DWORD_BYTE 4 This seems to be unused. thanks -- PMM
