Re: [PATCH 08/26] hw/ppc: Avoid using Monitor in spapr_xive_pic_print_info()

[Harsh Prateek Bora]

On 6/10/24 11:50, Philippe Mathieu-Daudé wrote:

@@ -203,10 +201,8 @@ static void spapr_xive_pic_print_info(SpaprXive *xive, 
Monitor *mon)
                  spapr_xive_end_pic_print_info(xive, end, buf);
              }

- info = human_readable_text_from_str(buf);

-            monitor_puts(mon, info->human_readable_text);
          }
-        monitor_printf(mon, "\n");
+        g_string_append_c(buf, '\n');

Ok, I see caller specific changes are done in separate patches.
Ideally one call flow could be squashed into a single patch, which would
help avoid addition, followed by removal of common logic like above.
However, assuming that would be increasing the patch size, I understand
smaller patches are easier to review.

Thanks
Harsh

      }
  }