On 6/17/24 15:49, Harsh Prateek Bora wrote:
Hi Phillipe,
One query below:
On 6/17/24 15:41, Harsh Prateek Bora wrote:
On 6/10/24 11:50, Philippe Mathieu-Daudé wrote:
Replace Monitor API by HumanReadableText one.
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Reviewed-by: Harsh Prateek Bora <hars...@linux.ibm.com>
---
include/hw/pci-host/pnv_phb3.h | 2 +-
hw/pci-host/pnv_phb3_msi.c | 21 ++++++++++-----------
hw/ppc/pnv.c | 8 +++++++-
3 files changed, 18 insertions(+), 13 deletions(-)
<snip>
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 6e3a5ccdec..5356a4e295 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -38,6 +38,7 @@
#include "hw/loader.h"
#include "hw/nmi.h"
#include "qapi/visitor.h"
+#include "qapi/type-helpers.h"
#include "monitor/monitor.h"
#include "hw/intc/intc.h"
#include "hw/ipmi/ipmi.h"
@@ -774,8 +775,13 @@ static void
pnv_chip_power8_pic_print_info(PnvChip *chip, Monitor *mon)
for (i = 0; i < chip8->num_phbs; i++) {
PnvPHB *phb = chip8->phbs[i];
PnvPHB3 *phb3 = PNV_PHB3(phb->backend);
+ g_autoptr(GString) buf = g_string_new("");
+ g_autoptr(HumanReadableText) info = NULL;
+
+ pnv_phb3_msi_pic_print_info(&phb3->msis, buf);
+ info = human_readable_text_from_str(buf);
+ monitor_puts(mon, info->human_readable_text);
- pnv_phb3_msi_pic_print_info(&phb3->msis, mon);
ics_pic_print_info(&phb3->lsis, mon);
How is the memory allocated to info in human_readable_text_from_str
being reclaimed here? Isnt it a mem leak ?
Ok, I see, g_autoptr takes care of auto cleanup. Please ignore.
Thanks
Harsh
}
}
