On 2/5/24 17:53, Paolo Bonzini wrote:
Move it to the existing "PIC related things" header, hw/intc/i8259.h.

Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
---
  include/hw/intc/i8259.h | 2 ++
  include/qemu/typedefs.h | 1 -
  2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h
index c4125757753..1f2420231f1 100644
--- a/include/hw/intc/i8259.h
+++ b/include/hw/intc/i8259.h
@@ -3,6 +3,8 @@
/* i8259.c */ +typedef struct PICCommonState PICCommonState;

I'd rather move from "hw/isa/i8259_internal.h" to here:

#define TYPE_PIC_COMMON "pic-common"
OBJECT_DECLARE_TYPE(PICCommonState, PICCommonClass, PIC_COMMON)

struct PICCommonState {
   ...
};

Can be done later, so meanwhile:

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to