On 2/5/24 17:53, Paolo Bonzini wrote:
Using QemuLockable almost always requires going through QEMU_MAKE_LOCKABLE().
Therefore, there is little point in having the typedef always present. Move
it to lockable.h, with only a small adjustment to coroutine.h (which has
a tricky co-dependency with lockable.h due to defining CoMutex *and*
using QemuLockable as a part of the CoQueue API).
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
---
include/qemu/coroutine.h | 4 ++--
include/qemu/lockable.h | 4 ++--
include/qemu/typedefs.h | 1 -
3 files changed, 4 insertions(+), 5 deletions(-)
Possibly squash:
-- >8 --
diff --git a/tests/unit/test-coroutine.c b/tests/unit/test-coroutine.c
index 49d4d9b251..32f2f5a746 100644
--- a/tests/unit/test-coroutine.c
+++ b/tests/unit/test-coroutine.c
@@ -13,6 +13,7 @@
#include "qemu/osdep.h"
#include "qemu/coroutine_int.h"
+#include "qemu/lockable.h"
/*
* Check that qemu_in_coroutine() works
---
to avoid the implicit inclusion via "qemu/coroutine_int.h".
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
