On Wed, 10 Apr 2024 18:06:03 +0200
Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
> sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
> resulting in painful developper experience. Use g_strdup_printf()
> instead.
Isn't this code only compiled for Linux hosts? Maybe still a valid
change, but the rationale seems irrelevant. Thanks,
Alex
>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> ---
> hw/vfio/pci.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 64780d1b79..cc3cc89122 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -2442,10 +2442,9 @@ void vfio_pci_post_reset(VFIOPCIDevice *vdev)
>
> bool vfio_pci_host_match(PCIHostDeviceAddress *addr, const char *name)
> {
> - char tmp[13];
> -
> - sprintf(tmp, "%04x:%02x:%02x.%1x", addr->domain,
> - addr->bus, addr->slot, addr->function);
> + g_autofree char *tmp = g_strdup_printf("%04x:%02x:%02x.%1x",
> + addr->domain, addr->bus,
> + addr->slot, addr->function);
>
> return (strcmp(tmp, name) == 0);
> }
