Hi Philippe, On 3/6/24 21:44, Philippe Mathieu-Daudé wrote: > On 6/3/24 21:32, Eric Auger wrote: >> We are missing an entry for the virtio-iommu-pci device. Add the >> information on which machine it is currently supported and document >> the new granule option. >> >> Signed-off-by: Eric Auger <eric.au...@redhat.com> >> --- >> qemu-options.hx | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/qemu-options.hx b/qemu-options.hx >> index 9a47385c15..757df3eac0 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -1172,6 +1172,14 @@ SRST >> Please also refer to the wiki page for general scenarios of VT-d >> emulation in QEMU: https://wiki.qemu.org/Features/VT-d. >> +``-device virtio-iommu-pci[,option=...]`` >> + This is only supported by ``-machine q35`` and ``-machine virt``. > > Don't we need to precise x86 and arm here? Well I got inspired of intel_iommu doc. I think this is sufficiently precise, no?
Thanks Eric > >> + It supports below options: >> + >> + ``granule=val`` (possible values are 4k, 8k, 16k, 64k and host; >> default: host) >> + This decides the default granule to be be exposed by the >> + virtio-iommu. If host, the granule matches the host page size. >> + >> ERST >> DEF("name", HAS_ARG, QEMU_OPTION_name, >