On Wed Feb 28, 2024 at 6:24 AM AEST, BALATON Zoltan wrote: > On Tue, 27 Feb 2024, BALATON Zoltan wrote: > > On Tue, 27 Feb 2024, Peter Maydell wrote: > >> On Tue, 27 Feb 2024 at 15:10, BALATON Zoltan <bala...@eik.bme.hu> wrote: > >>> > >>> Improve readability by shortening some long comments, removing > >>> comments that state the obvious and dropping some empty lines so they > >>> don't distract when reading the code. > >>> > >>> Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu> > >>> Acked-by: Nicholas Piggin <npig...@gmail.com> > >> > >> > >>> - /* > >>> - * new interrupt handler msr preserves existing ME unless > >>> - * explicitly overridden. > >>> - */ > >>> + /* new interrupt handler msr preserves ME unless explicitly > >>> overriden > >>> */ > >> > >> Minor typo introduced here: should be "overridden". > >> > >>> new_msr = env->msr & (((target_ulong)1 << MSR_ME)); > >> > >>> @@ -575,16 +558,10 @@ static void powerpc_excp_6xx(PowerPCCPU *cpu, int > >>> excp) > >>> /* new srr1 value excluding must-be-zero bits */ > >>> msr = env->msr & ~0x783f0000ULL; > >>> > >>> - /* > >>> - * new interrupt handler msr preserves existing ME unless > >>> - * explicitly overridden > >>> - */ > >>> + /* new interrupt handler msr preserves ME unless explicitly > >>> overriden > >>> */ > >> > >> Ditto, and similarly for other instances later in the patch. > > > > Huh, sorry, don't know how I've lost that letter. It also seems that the > > last > > patch gone missing from the series somehow so if it does not turn up, I can > > resend it with these fixed. > > As the last patch did not turn up I've resent just that to complete this > v7 series. Do I need to send v8 or if these typos are the only change > needed maybe they could be fixed up during merge.
I should be okay to do it. Thanks, Nick
