On 03/15/2012 04:55 AM, Avi Kivity wrote:
On 03/14/2012 10:33 PM, Anthony Liguori wrote:
On 03/06/2012 09:50 AM, Avi Kivity wrote:
The kvmvapic code remaps a section of ROM as RAM to allow the guest to
maintain state there.  It is careful to align the section size to a page
boundary, to avoid creating subpages, but neglects to do the same for
the start address.  These leads to an assert later on when the memory
core tries to create a page which is half RAM and half ROM.

Fix by aligning the start address to a page boundary.

This can be triggered by running qemu-system-x86_64 -enable-kvm -vga
none.

Signed-off-by: Avi Kivity<a...@redhat.com>

Tested-by: Anthony Liguori<aligu...@us.ibm.com>

Are you going to do a PULL request or do you want me to apply directly?

I forgot all about it, sorry.

No worries. I actually caught the bug in the original pull request but do to a bug in qemu-test, when I tried to bisect, things got weird and I mistakenly thought the real problem had been introduced earlier.

Regards,

Anthony Liguori




Reply via email to