On Mon, 26 Feb 2024 at 14:13, Zhao Liu <zhao1....@intel.com> wrote: > > Hi Peter, > > On Tue, Feb 20, 2024 at 04:06:17PM +0000, Peter Maydell wrote: > > Date: Tue, 20 Feb 2024 16:06:17 +0000 > > From: Peter Maydell <peter.mayd...@linaro.org> > > Subject: [PATCH 05/10] hw/core: Add documentation and license comments to > > reset.h > > X-Mailer: git-send-email 2.34.1 > > > > Add the usual boilerplate license/copyright comment to reset.h (using > > the text from reset.c), and document the existing functions. > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > --- > > include/sysemu/reset.h | 79 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 79 insertions(+) > > > > diff --git a/include/sysemu/reset.h b/include/sysemu/reset.h > > index 609e4d50c26..6aa11846a69 100644 > > --- a/include/sysemu/reset.h > > +++ b/include/sysemu/reset.h > > @@ -1,3 +1,29 @@ > > +/* > > + * Reset handlers. > > + * > > + * Copyright (c) 2003-2008 Fabrice Bellard > > + * Copyright (c) 2016 Red Hat, Inc. > > + * Copyright (c) 2024 Linaro, Ltd. > > An additional question, when there is a new (notable) contribution to a > file, then it's time to add the company's copyright. Right?
It's OK to do that; it's not obligatory. If you're contributing on behalf of a company you should generally follow whatever that company's policies are for copyright lines etc in open source projects. > > + * We assume that the caller holds the BQL. > > HMM, what does BQL stand for? "Big QEMU Lock", the one you get via BQL_LOCK_GUARD(). BQL is the standard abbreviation -- we already use it extensively both in comments in include/ and in docs/devel/. -- PMM
